test FlowInitialized event payload per config#447
Conversation
Pins three invariants on the `FlowInitialized` event emitted by `flowInit`: 1. One event per evaluable config (count == configs.length). 2. `sender` field equals the clone-factory caller. 3. `evaluable` field equals the deployer-returned (interpreter, store, expression) triple. Mutation verified: commenting out the `emit FlowInitialized` line makes the test fail (event count mismatch); reverting passes. Closes #325. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 3 minutes and 55 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolve import-block conflict in test/src/concrete/Flow.construction.t.sol as the union of both sides: keep main's EmptyFlowConfig/InsufficientFlowOutputs/UnsupportedFlowInputs and MIN_FLOW_SENTINELS imports plus this branch's EvaluableV2 import. All six FlowConstruction tests pass; forge build is clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Reviewed 25408d9: test FlowInitialized event payload per config — rebased onto main (test-only union conflict resolution + forge fmt), all checks green. LGTM. |
1 participant
Summary
Pins three invariants on the
FlowInitializedevent emitted byflowInit:configs.length).senderfield equals the clone-factory caller.evaluablefield equals the deployer-returned(interpreter, store, expression)triple.Mutation verified: commenting out the
emit FlowInitializedline makes the test fail (event count mismatch); reverting passes.Closes #325.
Test plan
testFlowConstructionEmitsFlowInitializedPerConfig— 100 fuzz runs (1–5 configs)emit FlowInitialized→ test fails🤖 Generated with Claude Code